[Webkit-unassigned] [Bug 40730] allow ports with windowed plugins to support windowless plugin tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40730


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59027|review?                     |review+
               Flag|                            |




--- Comment #7 from Simon Hausmann <hausmann at webkit.org>  2010-08-26 04:32:37 PST ---
(From update of attachment 59027)
WebCore/plugins/qt/PluginViewQt.cpp:297
 +      if (!xEvent->xkey.keycode) {
Perhaps this should be guarded with a drt run-time guard?

WebCore/plugins/qt/PluginViewQt.cpp:@
 +  void PluginView::setFocus(bool focused)
The changes in this function worry me a bit. Should sending the X focus event perhaps be guarded with !m_isWindowed or simply be moved into the else() block, in order to avoid that the event receives the X focus event twice, once through X itself (xembed) and once through the direct dispatchNPEvent() call.

The rest of the patch looks excellent to me! I'm sorry that it's been rotting away :(

I'm going to say r+ with the condition that the X focus event code should be moved so that it's not sent twice in case of windowed plugins.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.