[Webkit-unassigned] [Bug 44434] [chromium] Add chromium-side of AsyncFileSystem implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 25 15:55:54 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=44434





--- Comment #11 from Kinuko Yasuda <kinuko at chromium.org>  2010-08-25 15:55:54 PST ---
(In reply to comment #7)
> (From update of attachment 65209 [details])
> WebKit/chromium/src/LocalFileSystemChromium.cpp:47
>  +  using WebKit::WebFileSystemCallbacksImpl;
> nit: since you are in WebKit, I would just put a "using namespace WebKit" here, and
> then drop the WebKit:: prefixes down below.

Fixed.

(In reply to comment #8)
> (From update of attachment 65209 [details])
> WebKit/chromium/src/AsyncFileSystemChromium.h:46
>  +  class SecurityOrigin;
> super minor nit: is this forward decl needed?

Removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list