[Webkit-unassigned] [Bug 44433] Add AsyncFileSystem interface for platform-dependent FileSystem API implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44433





--- Comment #12 from Kinuko Yasuda <kinuko at chromium.org>  2010-08-25 15:21:56 PST ---
Thanks,

(In reply to comment #9)
> (From update of attachment 65460 [details])
> This looks pretty good to me.
> 
> WebCore/platform/AsyncFileSystem.h:65
>  +      virtual void move(const String& srcPath, const String& destPath, PassOwnPtr<AsyncFileSystemCallbacks>) = 0;
> Should we add comments to indicate which of the callbacks is invoked on success and on error? I guess its usually didSucceed() or didFail(int error), maybe a general comment to that affect and than call out those that deviate from that.

Added comments.

> WebCore/platform/AsyncFileSystemCallbacks.h:54
>  +      virtual void didReadDirectoryEntry(const String& name, bool isDirectory) = 0;
> What calls is didReadDirectoryEntry(...) and didReadDirectoryChunkDone(...) in response to?

Added AsyncFileSystem::readDirectory()... it was missing in the previous patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.