[Webkit-unassigned] [Bug 44539] API changes for Video Frame sharing between WebKit and Chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44539


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65477|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #12 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-08-25 15:18:58 PST ---
(From update of attachment 65477)
WebKit/chromium/public/WebMediaPlayer.h:132
 +      // For getting frames to and from media player.
nit: Something like the comments on VideoFrameProvider should be here as well.
Ideally, the user of the WebKit API should not need to read WebCore files to
understand how to use the API.

WebKit/chromium/public/WebVideoFrame.h:31
 +  
nit: extra new line here that should be removed

WebKit/chromium/public/WebVideoFrame.h:41
 +      // These enums must be kept in sync with media::VideoFormat.
nit: I'd prefer that we avoid references to code in the Chromium repository.
These things can easily get out of sync as folks changing code in Chromium
may not realize they need to make a patch to WebKit to fix up the name of
something.  I'd just drop this comment.

WebKit/chromium/src/VideoFrameChromiumImpl.h:46
 +      static WebVideoFrame* toWebVideoFrame(VideoFrameChromium*);
nit: i'd recommend a new line after here for readability

R=me w/ these nits fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.