[Webkit-unassigned] [Bug 44337] [EFL] Added new callback when view's size is changed to fix issue with changing layout size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44337





--- Comment #4 from Lucas De Marchi <demarchi at webkit.org>  2010-08-25 13:47:08 PST ---
(From update of attachment 64960)
> diff --git a/WebKit/efl/ChangeLog b/WebKit/efl/ChangeLog
> index de65885..2887fd4 100644
> --- a/WebKit/efl/ChangeLog
> +++ b/WebKit/efl/ChangeLog
> @@ -1,3 +1,13 @@
> +2010-08-20  Miroslaw Szymanski  <miroslaw.s at samsung.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [EFL] Added new callback when view's size is changed to fix issue with changing layout size
> +        https://bugs.webkit.org/show_bug.cgi?id=44337
> +
> +        * ewk/ewk_view.cpp:
> +        (_ewk_view_smart_calculate):
> +
>  2010-08-15  Gyuyoung Kim  <gyuyoung.kim at samsung.com>
>  
>          Reviewed by Antonio Gomes.
> diff --git a/WebKit/efl/ewk/ewk_view.cpp b/WebKit/efl/ewk/ewk_view.cpp
> index 7a98bac..5e19386 100644
> --- a/WebKit/efl/ewk/ewk_view.cpp
> +++ b/WebKit/efl/ewk/ewk_view.cpp
> @@ -792,6 +792,9 @@ static void _ewk_view_smart_calculate(Evas_Object* o)
>          sd->changed.frame_rect = EINA_TRUE;
>          sd->view.w = w;
>          sd->view.h = h;
> +
> +        // This callback is a good place e.g. to change fixed layout size (ewk_view_fixed_layout_size_set)
> +        evas_object_smart_callback_call(o, "view,resized", 0);
>      }
>      sd->changed.size = EINA_FALSE;
>  

lgtm, except by the fact it's missing the documentation about the signal emitted. Please, fill the doc in ewk_view.h

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.