[Webkit-unassigned] [Bug 44433] Add AsyncFileSystem interface for platform-dependent FileSystem API implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44433





--- Comment #10 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-08-25 13:47:02 PST ---
(From update of attachment 65460)
WebCore/storage/LocalFileSystem.cpp:72
 +      AsyncFileSystem::openFileSystem(m_basePath, context->securityOrigin()->databaseIdentifier(), type, new FileSystemCallbacks(successCallback, errorCallback, context, asyncFileSystem.release()));
it seems a bit awkward that openFileSystem is a static method and not an instance
method on AsyncFileSystem.  you have an instance of AsyncFileSystem here.

WebCore/storage/LocalFileSystem.h:52
 +      void requestFileSystem(ScriptExecutionContext*, AsyncFileSystem::Type type, long long size, PassRefPtr<FileSystemCallback>, PassRefPtr<ErrorCallback>);
nit: leave off the "type" parameter name here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.