[Webkit-unassigned] [Bug 44603] shadowSize parameter is used to pass shadow offset in the GraphicsContext::setShadow and getShadow functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44603


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mitz at webkit.org




--- Comment #5 from mitz at webkit.org  2010-08-25 09:30:34 PST ---
(In reply to comment #2)
> After changing the names I've realized that this condition could be wrong but the old name could make it seem correct:
> 
> +            drawIntoBitmap = !offset.isEmpty() || blur;
> 
> It is in this file: WebCore/platform/graphics/win/FontCGWin.cpp static void drawGDIGlyphs
> 
> Could someone check if in Windows negative offsets of the text actually work, or no offsets but blurring. We could open a new bug in this case.

I’ve asked someone to check, and indeed in <data:text/html,%3Cdiv%20style=%22-webkit-font-smoothing:%20none%22%3E%3Cdiv%20style=%22text-shadow:%202px%202px%20red%22%3Etest%3C/div%3E%3Cdiv%20style=%22text-shadow:%20-2px%20-2px%20red%22%3Etest%3C/div%3E%3C/div%3E> the bottom line is missing the shadow. Good catch!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.