[Webkit-unassigned] [Bug 44508] [EFL] Add PlatformVideoWindowEfl.cpp for WebKit EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44508





--- Comment #22 from Rafael Antognolli <antognolli at profusion.mobi>  2010-08-25 07:24:22 PST ---
(In reply to comment #12)
> (In reply to comment #11)
> > 
> > > I modify above code as below,
> > > 
> > >  31 #elif PLATFORM(EFL)
> > >  32 #if ENABLE(GLIB_SUPPORT)
> > >  33 #include <glib.h>
> > >  34 #endif
> > >  35 #include "Widget.h"
> > >  36 typedef PlatformWidget PlatformWindowType;
> > >  37 #endif
> > > 
> > > Is this ok ?
> > 
> 
> Well I understand your port doesn't have a hard dependency on GLib, so yeah you need guards, maybe like:
> 
> #if PLATFORM(GTK) || ENABLE(GLIB_SUPPORT)
> #include <glib.h>
> #endif
> 
> ?

Actually, no guards are needed since Gyuyoung's patch is for gstreamer video backend, and gstreamer needs glib anyway. We even force ENABLE_GLIB_SUPPORT if ENABLE_VIDEO_SUPPORT is true.

Maybe if later another video implementation that doesn't use gstreamer is available, the yes, we could make this optional. And I think the following line (unless changed to something else with ifdefs too) wouldn't compile without #include <glib.h>:
         gulong videoWindowId() const { return m_videoWindowId; }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.