[Webkit-unassigned] [Bug 44508] [EFL] Add PlatformVideoWindowEfl.cpp for WebKit EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44508





--- Comment #19 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2010-08-25 03:04:19 PST ---
(In reply to comment #18)
> (From update of attachment 65388 [details])
> Nice, thanks :)
> One last thing (from my side, at least):
> 
> > #if PLATFORM(GTK)
> > #include <gtk/gtk.h>
> >-typedef GtkWidget PlatformWindowType;
> >+#endif
> 
> That #if can be removed all together. We no longer require to include gtk.h there but then we should move it to PlatformVideoWindowGtk.cpp I think. But as this patch is EFL-specific I can make that change myself in a separate patch.

I couldn't remove "#include <gtk/gtk.h>" because of build error in PlatformVideoWindowGtk.cpp. If you want to move "#include <gtk/gtk.h>" to PlatformVideoWindowGtk.cpp, I can do it new patch. Do you want ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.