[Webkit-unassigned] [Bug 44508] [EFL] Add PlatformVideoWindowEfl.cpp for WebKit EFL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 24 23:13:08 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=44508





--- Comment #7 from Philippe Normand <pnormand at igalia.com>  2010-08-24 23:13:07 PST ---
(In reply to comment #6)
> (In reply to comment #3)
> > (From update of attachment 65250 [details] [details])
> > 
> > >+#if PLATFORM(EFL)
> > >+#if ENABLE(GLIB_SUPPORT)
> > >+#include <glib.h>
> > >+#endif
> > >+#endif
> > >+
> > 
> > I think the guards can be removed because glib.h is required for the use of gulong below anyway.
> > The only reason why it works currently is that gtk.h includes glib.h
> 
> WebKit EFL doesn't use gtk. So, I include glib.h for EFL. Is this wrong ?

It is totally right, I was just asking to remove the #ifs

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list