[Webkit-unassigned] [Bug 44537] WebKit2 should launch the WebProcess in 32-bit mode if the UIProcess is in 32-bit mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44537


Mark Rowe (bdash) <mrowe at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65362|review?                     |review+
               Flag|                            |




--- Comment #3 from Mark Rowe (bdash) <mrowe at apple.com>  2010-08-24 20:05:20 PST ---
(From update of attachment 65362)
> +
> +    posix_spawnattr_t attr;
> +    posix_spawnattr_init(&attr);
> +
> +#if CPU(X86)
> +    // We spawn a 32-bit child process if the host is 32-bit. This allows checking
> +    // the "Open in 32-bit mode" check box in the finder and getting a 32-bit WebProcess.

I don’t like the way this comment is worded.  It would be better to say something about having the child process run as the same architecture as the parent process.  The Finder in particular isn’t all that interesting here.

> +    cpu_type_t cpuTypes[] = { CPU_TYPE_X86 };    
> +#else
> +    cpu_type_t cpuTypes[] = { CPU_TYPE_ANY };
> +#endif
> +    size_t outCount = 0;
> +    posix_spawnattr_setbinpref_np(&attr, 1, cpuTypes, &outCount);

You could move this call in to the #if and drop the #else completely.

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.