[Webkit-unassigned] [Bug 44561] New: [Cairo][REGRESSION] Overzealous Use of Gtk-Specific Smart Pointers Breaks other Builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44561

           Summary: [Cairo][REGRESSION] Overzealous Use of Gtk-Specific
                    Smart Pointers Breaks other Builds
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: bfulgham at webkit.org


Changes to the ImageCairo.cpp class (see @r65530) involved changes that used smart pointers on various Cairo data types.  While I applaud this concept, the implementor made the unfortunate decision to use a GPtr-based implementation, rather than building on existing platform-agnostic WebKit smart pointer types.

Since the ImageCairo class is not a Gtk-specific class, this violation of API separation creates build problems.

As far as I can tell, the specific instances in ImageCairo.cpp where GPtr-based smart pointers are used could be replaced with a non-Gtk-specific implementation.

This issue will make this change to resolve this build regression.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.