[Webkit-unassigned] [Bug 44539] API changes for Video Frame sharing between WebKit and Chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44539





--- Comment #2 from Victoria <vrk at google.com>  2010-08-24 11:21:11 PST ---
Hi Darin! Could you take a look at this patch when you have time? I tried to address the concerns you and others mentioned in the previous review.

Some key points:

* This patch only contains the API changes and doesn't actually use the classes/methods yet. This is both so that it is hopefully easier to review, and also because I need to land a patch on the Chromium side before I can use these classes without breaking the build.

* WebVideoFrame interface does not contain enums and instead returns "unsigned" for the format/surface type. WebVideoFrame is intended to be a proxy between VideoFrameChromium and media::VideoFrame anyway, so it seemed like a reasonable trade-off to eliminate the enums from WebVideoFrame. 

* I didn't add anything to AssertMatchingEnums.cpp because (in light of the change mentioned above) I need to match enums between WebCore and Chromium, not WebCore and WebKit. Do you know of a way to do this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.