[Webkit-unassigned] [Bug 44288] MarkupAccumulator::appendStartMarkup should be broken down into pieces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44288





--- Comment #15 from Darin Adler <darin at apple.com>  2010-08-24 11:09:26 PST ---
(In reply to comment #11)
> (From update of attachment 64993 [details])
> WebCore/editing/markup.cpp:490
>  +      const QualifiedName* parentName = 0;
> I'm not sure I understand why we use a pointer here.  It seems using a QualifiedName local would work just as well. I can't imagine its any slower since QualifiedName it itself just a RefPtr.

I think a pointer is a good way to handle an optional value. Also, a RefPtr is slower than a raw pointer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.