[Webkit-unassigned] [Bug 44527] [Qt] Implement WebKit::Module for qt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44527


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65281|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-08-24 09:29:53 PST ---
(From update of attachment 65281)
WebKit2/Platform/qt/ModuleQt.cpp:34
 +      // Try to remove the file suffix if the path contains it.
Try removing... 

You don't say why.

WebKit2/Platform/qt/ModuleQt.cpp:35
 +      QString path = static_cast<QString>(m_path);
What is m_path?

WebKit2/Platform/qt/ModuleQt.cpp:37
 +      if ((lastIndex = path.lastIndexOf(QString(".so"))) >= 0)
QLatin1String please

WebKit2/Platform/qt/ModuleQt.cpp:39
 +      else if ((lastIndex = path.lastIndexOf(QString(".dll"))) >= 0)
Same here

Apart from this it looks sane.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.