[Webkit-unassigned] [Bug 44508] [EFL] Add PlatformVideoWindowEfl.cpp for WebKit EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44508





--- Comment #4 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2010-08-24 05:15:58 PST ---
(In reply to comment #3)
> (From update of attachment 65250 [details])
> 
> >+#if PLATFORM(EFL)
> >+#if ENABLE(GLIB_SUPPORT)
> >+#include <glib.h>
> >+#endif
> >+#endif
> >+
> 
> I think the guards can be removed because glib.h is required for the use of gulong below anyway.
> The only reason why it works currently is that gtk.h includes glib.h
> 
> > namespace WebCore {
> > 
> > class PlatformVideoWindow : public RefCounted<PlatformVideoWindow> {
> >@@ -39,12 +45,16 @@ class PlatformVideoWindow : public RefCounted<PlatformVideoWindow> {
> >         PlatformVideoWindow();
> >         ~PlatformVideoWindow();
> > 
> >+#if PLATFORM(GTK)
> >         PlatformWindowType* window() const { return m_window; }
> >+#endif
> 
> >         gulong videoWindowId() const { return m_videoWindowId; }
> > 
> >     private:
> >         gulong m_videoWindowId;
> >+#if PLATFORM(GTK)
> >         PlatformWindowType* m_videoWindow;
> >+#endif
> 
> This is wrong. You need to add a typedef for your platform so PlatformWindowType is valid.

I agree with your opinion. I am going to consider your guidance.

Thank you.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.