[Webkit-unassigned] [Bug 44424] Web Inspector: show DOM breakpoints in sidebar pane

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44424


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65252|review?, commit-queue?      |
               Flag|                            |




--- Comment #6 from Pavel Feldman <pfeldman at chromium.org>  2010-08-24 05:09:48 PST ---
(From update of attachment 65252)
Great job! Please fix style nits and we can land this.

General nit: Instead of setting listeners to the individual breakpoints, you should add single one to the breakpoint manager.WebCore/inspector/front-end/BreakpointsSidebarPane.js:202
(can be done later)

 +  WebInspector.DOMBreakpointItem.Labels[WebInspector.DOMBreakpoint.Types.SubtreeModified] = "Subtree Modified";
It is better to move UIString call here.

WebCore/inspector/front-end/BreakpointsSidebarPane.js:212
 +      element: WebInspector.JSBreakpointItem.prototype.element,
You should either inherit or aggregate.
WebCore/inspector/front-end/inspector.js:203
 +          WebInspector.breakpointManager.addEventListener("breakpoint-added", function(event)
Please follow style guidelines when declaring functions.

WebCore/inspector/front-end/inspector.js:213
 +          WebInspector.domBreakpointManager.addEventListener("dom-breakpoint-added", function(event)
ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.