[Webkit-unassigned] [Bug 43259] Add the shadow offset as a parameter to the GraphicsContext::setShadow

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 24 05:09:45 PDT 2010


--- Comment #17 from Alejandro G. Castro <alex at igalia.com>  2010-08-24 05:09:44 PST ---
(In reply to comment #15)
> > Basically we need the part the shadow that is not under the figure that causes that shadow. 
> Unless I miss something, this could be carried out in a different way using the clip region (like in #44091).

I've checked the code and maybe I'm missing something, again :), but I double checked the clipped area bounding box is the shadow rect or a piece of that rect, so we still do not have the original rect location information to know the offset of the shadow.

This patch actually also required to clean the use of the size parameter as an offset in the setShadow function anyway. I would say after the patch we should try to remove the size parameter with patches for each port moving the offset calculations required by those port shadows APIs to the port code.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list