[Webkit-unassigned] [Bug 44434] [chromium] Add chromium-side of AsyncFileSystem implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44434





--- Comment #3 from Michael Nordman <michaeln at google.com>  2010-08-23 19:52:12 PST ---
(From update of attachment 65202)
Some drive by comments.

WebKit/chromium/src/AsyncFileSystemChromium.cpp:55
 +  static PassOwnPtr<AsyncFileSystem> createPlatformAsyncFileSystem()
I don't follow this static function definition, its not called in this module so what purpose does it serve?

WebKit/chromium/src/LocalFileSystemChromium.cpp:70
 +  COMPILE_ASSERT_MATCHING_ENUM(Persistent);
Most of these are in AssertMatchingEnums.cpp, unless there's a compelling reason to have these separated out, I think these should also be in that .cpp file.

WebKit/chromium/src/AsyncFileSystemChromium.cpp:64
 +  {
maybe ASSERT(m_webFileSystem)

WebKit/chromium/src/LocalFileSystemChromium.cpp:60
 +          WebFrameImpl* webFrame = WebFrameImpl::fromFrame(document->frame());
Is there any chance script can be executing in a document that has been detached from its frame? IDK?

WebKit/chromium/src/AsyncFileSystemChromium.h:36
 +  namespace WebKit { class WebFileSystem; }
I would expect in webkit style that the forward decl would go after the includes (not positive about that).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.