[Webkit-unassigned] [Bug 44433] Add AsyncFileSystem interface for platform-dependent FileSystem API implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44433





--- Comment #7 from Kinuko Yasuda <kinuko at chromium.org>  2010-08-23 16:50:24 PST ---
Thanks for your comments.

(In reply to comment #4)
> (From update of attachment 65146 [details])
> WebCore/platform/AsyncFileSystemCallbacks.h:48
>  +      virtual void didOpenFileSystem(const String& name, const String& rootPath) = 0;
> If this callback was void didOpenFileSystem(PassOwnPtr<AsyncFileSystem> result) could we avoid the need for the AsyncFileSystemFactory class? Effectively the openFileSystem() method is a factory method that returns asyncly.

Well, because I wanted to put AsyncFileSystem under platform there're some layering issues around it.  For non-chromium version I'm planning to add a thread version of AsyncFileSystem implementation but it reguires high-level classes (e.g. ScriptExecutionContext) and thus needs to be created (or set via factory) at higher level.

I removed the factory class and changed the code to create AsyncFileSystem before calling openFileSystem.  I also included LocalFileSystem class in the patch to give some idea how AsyncFileSystem is going to be created in non-chromium cases.  (I tried to make this layering look prettier but haven't succeeded yet...)

> WebCore/storage/DOMFileSystem.h:69
>  +      DOMFileSystem(ScriptExecutionContext*, const String& name, AsyncFileSystem*);
> Should this be PassOwnPtr<AFS> ?

Fixed.

> WebCore/storage/DOMFileSystem.h:50
>  +      static PassRefPtr<DOMFileSystem> create(ScriptExecutionContext* context, const String& name, AsyncFileSystem* asyncFileSystem)
> PassOwnPtr<AFS> here too?

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.