[Webkit-unassigned] [Bug 44433] Add AsyncFileSystem interface for platform-dependent FileSystem API implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44433





--- Comment #4 from Michael Nordman <michaeln at google.com>  2010-08-23 13:37:04 PST ---
(From update of attachment 65146)
Some drive by comments.

WebCore/platform/AsyncFileSystemCallbacks.h:48
 +      virtual void didOpenFileSystem(const String& name, const String& rootPath) = 0;
If this callback was void didOpenFileSystem(PassOwnPtr<AsyncFileSystem> result) could we avoid the need for the AsyncFileSystemFactory class? Effectively the openFileSystem() method is a factory method that returns asyncly.

WebCore/storage/DOMFileSystem.h:69
 +      DOMFileSystem(ScriptExecutionContext*, const String& name, AsyncFileSystem*);
Should this be PassOwnPtr<AFS> ?

WebCore/storage/DOMFileSystem.h:50
 +      static PassRefPtr<DOMFileSystem> create(ScriptExecutionContext* context, const String& name, AsyncFileSystem* asyncFileSystem)
PassOwnPtr<AFS> here too?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.