[Webkit-unassigned] [Bug 44256] [EFL] Private Browsing feature for WebKit-Efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44256





--- Comment #4 from Rafael Antognolli <antognolli at profusion.mobi>  2010-08-23 11:17:32 PST ---
Hi Grzegorz, just some comments about your patch:

First, I agree with Gyuyoung, I'd put the cookies part inside ewk_cookies.cpp. Another comment:

+Eina_Bool _ewk_replace_cookie_jar(Eina_Bool enable)
+{
+#if USE(SOUP)
+    static Eina_Bool current_status_of_pb = EINA_FALSE;
+
+    if (current_status_of_pb == enable)
+        return EINA_FALSE;

What does it mean if you return false here? I think in cases where the setting you are trying to put is valid, but is already set, you should don't do nothing and just return true, instead of false. If you want a different behavior, document it on the doxygen string of the function, since this is the default one for most of our functions.

And I also don't like the idea of these static variables inside the function. They seem a little lost inside it. A better approach would be to add it to a struct somewhere.

Another question is: does this conflict with the bug 44239 ? I think if you are in private browsing mode, maybe you shouldn't store any page for offline use. What do you think about this?

Regards,
Rafael

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.