[Webkit-unassigned] [Bug 44239] [EFL] Enable offline pages cache (patch)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44239


Rafael Antognolli <antognolli at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |antognolli at profusion.mobi




--- Comment #4 from Rafael Antognolli <antognolli at profusion.mobi>  2010-08-23 10:23:28 PST ---
Some comments about the patch:

>      WebCore::PageGroup::setShouldTrackVisitedLinks(true);
>  
>      // set default location of web database path

Maybe you should bring this comment together with the call ewk_settings_web_database_path_set?

> -    ewk_settings_web_database_path_set(getenv("HOME"));
> +    { // this block is because of gotos

Do you really need this block? What's the difference if you don't have it? Considering my comments below of removing the std::string, you wouldn't need this anymore (and I didn't get the gotos idea).

> +        using namespace std;
> +        // set default location of web database path
> +        const char* home = getenv("HOME");
> +        if (!home) // don't forget about the homeless
> +            home = "/tmp"; // this directory must always exist
> +        string wkdir = string(home) + "/.webkit";

We are not using "string" anywhere else in WebKit-EFL. So, could you use C functions for creating this string, like snprintf (since you are later converting to c_str() anyway). Or maybe using WebCore's ones? Then you wouldn't need to include <string>.

> --- WebKit/efl/ewk/ewk_view.cpp	(revision 65660)
> +++ WebKit/efl/ewk/ewk_view.cpp	(working copy)
> @@ -559,6 +559,7 @@ static Ewk_View_Private_Data* _ewk_view_
>      priv->page_settings->setJavaScriptEnabled(true);
>      priv->page_settings->setPluginsEnabled(true);
>      priv->page_settings->setLocalStorageEnabled(true);
> +    priv->page_settings->setOfflineWebApplicationCacheEnabled(true);

Like the other page settings, you need to add a member of the struct priv->settings for it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.