[Webkit-unassigned] [Bug 44174] Web Inspector: extract profiler-related code and data from InspectorController into ProfilerAgent

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 23 01:49:08 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=44174


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65087|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #11 from Pavel Feldman <pfeldman at chromium.org>  2010-08-23 01:49:07 PST ---
(From update of attachment 65087)
WebCore/inspector/InspectorController.cpp:1470
 +  bool InspectorController::isRecordingUserInitiatedProfile() const
I'd rather get rid of the usage in the WebKit layer. WebKit is starting and stopping it, why doesn't it track its own state? Also, I'd implement user initiated profiling in the WebKit layer as a whole...

WebCore/inspector/InspectorProfilerAgent.cpp:62
 +          : m_inspectorController(inspectorController)
Too many spaces.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list