[Webkit-unassigned] [Bug 44383] Encapsulate document marker management into DocumentMarkerController

Sat Aug 21 14:35:06 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=44383

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65035|review?                     |review+
               Flag|                            |

--- Comment #2 from Eric Seidel <eric at webkit.org>  2010-08-21 14:35:06 PST ---
(From update of attachment 65035)
Yay!  Thank you Dan!

WebCore/dom/Document.h:1173
 +      mutable DocumentMarkerController m_markerController;
It's better for build times if this is an OwnPtr instead.  When its a mutable member you have to include the header in Document.h.   The only reason (I know of) to make these mutable members is to avoid the pointer indirection in hot code paths.  But I don't think DocumentMarkers are hot.  This is not a deal breaker either way.

WebCore/dom/DocumentMarkerController.h:48
 +      void copyMarkers(Node *srcNode, unsigned startOffset, int length, Node *dstNode, int delta, DocumentMarker::MarkerType = DocumentMarker::AllMarkers);
Style.

WebCore/editing/Editor.cpp:1566
 +          frame()->document()->markerController()->removeMarkers(selectedRange.get(), DocumentMarker::Spelling);
I might have called the markerController() just markers().

LGTM.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.