[Webkit-unassigned] [Bug 44375] Copying Paths is expensive. toPathData() should avoid causing a copy.

Sat Aug 21 09:21:57 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=44375

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65026|Patch                       |one possible approach
        description|                            |

--- Comment #4 from Eric Seidel <eric at webkit.org>  2010-08-21 09:21:57 PST ---
(From update of attachment 65026)
This doesn't really change our performance on http://themaninblue.com/experiment/AnimationBenchmark/svg/

I think a better approach would be the one mentioned in 44374 of using the unit circle and transforming it.

This might speed up some painting ever so slightly, since we're not copying Paths as much.  All of the uses of Path::create* were causing a Path copy.

In the shark sample, this brought our time spent under SVGCircleElement::toPathData up to 8.9% after the change, but before the change, toPathData + Path::operator= + CFRelease (which were all related to copying paths) was over 12% in total.

I'm not sure if I should finish this land this patch or not, but I'm putting it here for comments anyway.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.