[Webkit-unassigned] [Bug 44342] [GTK] Inspector extensions tests fail on GTK+ bots because onSelectionChanged is missing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44342





--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org>  2010-08-20 16:44:22 PST ---
(From update of attachment 65008)
> diff --git WebCore/GNUmakefile.am
>  # RemoteInspectorFrontend and InspectorBackendDispatcher
> -DerivedSources/WebCore/RemoteInspectorFrontend.cpp DerivedSources/WebCore/RemoteInspectorFrontend.h DerivedSources/WebCore/InspectorBackendDispatcher.cpp DerivedSources/WebCore/InspectorBackendDispatcher.h: $(WebCore)/inspector/Inspector.idl $(SCRIPTS_BINDINGS) $(WebCore)/inspector/CodeGeneratorInspector.pm
> +DerivedSources/WebCore/RemoteInspectorFrontend.cpp DerivedSources/WebCore/RemoteInspectorFrontend.h DerivedSources/WebCore/InspectorBackendDispatcher.cpp DerivedSources/WebCore/InspectorBackendDispatcher.h DerivedSources/WebCore/InspectorBackendStub.js: $(WebCore)/inspector/Inspector.idl $(SCRIPTS_BINDINGS) $(WebCore)/inspector/CodeGeneratorInspector.pm

The comment above this should be updated as well. Maybe just
something like: "All Web Inspector Generated Files"


> +${GENSOURCES_INSPECTOR}/inspector.html: $(WebCore)/inspector/front-end/*.html \
> +		$(WebCore)/inspector/front-end/*.js $(WebCore)/inspector/front-end/*.css \
> ...
>  	mkdir -p ${GENSOURCES_INSPECTOR}/images
>  	cp ${dist_webinspector_DATA} ${GENSOURCES_INSPECTOR}
>  	cp ${dist_webinspectorimages_DATA} ${GENSOURCES_INSPECTOR}/images


Separate these two lines, it makes it easier to read.
And can you instead change the variable (dist_webinspector_DATA)
to include the full paths? I'm surprised the `cp` later on
works if that didn't have the proper paths.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.