[Webkit-unassigned] [Bug 44258] Added WebCore::Document and Webkit-EFL API which returns position of n-th text matches mark.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44258


Rafael Antognolli <antognolli at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |antognolli at profusion.mobi




--- Comment #6 from Rafael Antognolli <antognolli at profusion.mobi>  2010-08-20 15:11:19 PST ---
Hi Kamil. I just did a quick look over the WebCore::Document part, and didn't see any problem, but I think some reviewer that understands deeply that part of code should take a look at it. So maybe you should find who recently contributed to it and add to cc too.

I'm not sure, but I also think that this should be split into two patches. One adding the Document::firstRectsForMarkers, and another one using this functionality inside WebKit-EFL.

And please, pay attention to the coding style in ewk_frame.cpp. It does use WebKit coding style (as all the c++ files inside ewk/). So the pointers should be declared as:

Evas_Object* o;

instead of

Evas_Object *o;

Regards,
Rafael

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.