[Webkit-unassigned] [Bug 44127] [chromium] Thumbnails not generated for GPU Rendered Pages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44127





--- Comment #14 from W. James MacLean <wjmaclean at chromium.org>  2010-08-20 06:01:01 PST ---
(In reply to comment #13)
> 
> I think that since you opted for a more general solution of integrating the readback in the paint method (which is a good thing), you cannot make assumptions on how this method will be called and whether the compositor will have rendered something before.  I think splitting out the swapbuffers call is worth it here, and is a fairly small change.

No problem, I just wanted to be clear about this since we had discussed pure read-back earlier.

I'll implement this today, but as I'm working OOO today I may not be able to test the changes until Monday morning, so will re-submit the patch then.

> > > WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:518
> > >  +      glReadPixels(0, 0, width, height,
> > > Are there any guarantees that the width and height passed in match those of the framebuffer? You should probably at a minimum put an assert there and/or clamp to the size of the framebuffer.
> > 
> > Good idea - should I compare/clamp against m_rootLayerTextureWidth/Height ?
> 
> yes, those are good values to clamp against.

Done!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.