[Webkit-unassigned] [Bug 44174] Web Inspector: extract profiler-related code and data from InspectorController into ProfilerAgent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44174


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64857|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #8 from Pavel Feldman <pfeldman at chromium.org>  2010-08-20 04:49:15 PST ---
(From update of attachment 64857)
WebCore/inspector/InspectorController.cpp:177
 +      // Needed for 'console.profile' to work.
This seems wrong. JSC does not require this for console.profile to work?

WebCore/inspector/InspectorController.cpp:506
 +      String profilerEnabledSetting = setting(profilerEnabledSettingName);
we should not perform this check in case profiler is always enabled?

WebCore/inspector/InspectorProfilerAgent.h:64
 +      void setRemoteFrontend(RemoteInspectorFrontend* frontend) { m_remoteFrontend = frontend; }
By the nature of your agent, all the calls to it should be of query form (initiated from the front-end side). You should not need remoteFrontend reference for it to work.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.