[Webkit-unassigned] [Bug 42886] Web Inspector: implement DOM breakpoints

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42886





--- Comment #23 from Pavel Podivilov <podivilov at chromium.org>  2010-08-20 04:35:15 PST ---
(In reply to comment #20)
> (From update of attachment 64846 [details])
> WebCore/inspector/InspectorDOMAgent.cpp:1061
>  +                  m_breakpoints.set(node, derivedMask);
> I still don't like that we implicitly assume here that the node is one that has just been added and has no current flags. Let's make the code work for all nodes including those that already have non-0 mask.
> 
> WebCore/inspector/InspectorDOMAgent.cpp:1050
>  +  void InspectorDOMAgent::updateSubtreeBreakpoints(Node* root, long mask, bool set, bool recursive)
> Please remove recursive flag as discussed offline and make the function always recursive.

updateSubtreeBreakpoints rewritten as discussed offline.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.