[Webkit-unassigned] [Bug 44239] [Patch] Enable offline pages cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44239


Mikołaj Małecki <m.malecki at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64826|                            |review?, commit-queue?
               Flag|                            |




--- Comment #2 from Mikołaj Małecki <m.malecki at samsung.com>  2010-08-20 03:31:18 PST ---
(From update of attachment 64826)
> Index: WebKit/efl/ChangeLog
> ===================================================================
> --- WebKit/efl/ChangeLog	(revision 65660)
> +++ WebKit/efl/ChangeLog	(working copy)
> @@ -1,3 +1,14 @@
> +2010-08-19  Mikołaj Małecki  <m.malecki at samsung.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [EFL] Enabled offline pages storage for WebKit EFL; fixed default location of offline cache files
> +
> +        * ewk/ewk_main.cpp:
> +        (ewk_init): Fixed location of offline cache file
> +        * ewk/ewk_view.cpp:
> +        (_ewk_view_priv_new): Added setting to enable offline pages
> +
>  2010-08-15  Gyuyoung Kim  <gyuyoung.kim at samsung.com>
>  
>          Reviewed by Antonio Gomes.
> Index: WebKit/efl/ewk/ewk_main.cpp
> ===================================================================
> --- WebKit/efl/ewk/ewk_main.cpp	(revision 65660)
> +++ WebKit/efl/ewk/ewk_main.cpp	(working copy)
> @@ -21,10 +21,12 @@
>  #include "config.h"
>  #include "ewk_main.h"
>  
> +#include "ApplicationCacheStorage.h"
>  #include "EWebKit.h"
>  #include "Logging.h"
>  #include "PageCache.h"
>  #include "PageGroup.h"
> +#include <string>
>  #include "ewk_private.h"
>  #include "ewk_settings.h"
>  #include "runtime/InitializeThreading.h"
> @@ -118,7 +120,18 @@ int ewk_init(void)
>      WebCore::PageGroup::setShouldTrackVisitedLinks(true);
>  
>      // set default location of web database path
> -    ewk_settings_web_database_path_set(getenv("HOME"));
> +    { // this block is because of gotos
> +        using namespace std;
> +        // set default location of web database path
> +        const char* home = getenv("HOME");
> +        if (!home) // don't forget about the homeless
> +            home = "/tmp"; // this directory must always exist
> +        string wkdir = string(home) + "/.webkit";
> +        ewk_settings_web_database_path_set(wkdir.c_str());
> +
> +        // FIXME: It should be possible for client applications to override the default appcache location
> +        WebCore::cacheStorage().setCacheDirectory(wkdir.c_str());
> +    }
>  
>      // TODO: this should move to WebCore, already reported to webkit-gtk folks:
>  #ifdef WTF_USE_SOUP
> Index: WebKit/efl/ewk/ewk_view.cpp
> ===================================================================
> --- WebKit/efl/ewk/ewk_view.cpp	(revision 65660)
> +++ WebKit/efl/ewk/ewk_view.cpp	(working copy)
> @@ -559,6 +559,7 @@ static Ewk_View_Private_Data* _ewk_view_
>      priv->page_settings->setJavaScriptEnabled(true);
>      priv->page_settings->setPluginsEnabled(true);
>      priv->page_settings->setLocalStorageEnabled(true);
> +    priv->page_settings->setOfflineWebApplicationCacheEnabled(true);
>  
>      url = priv->page_settings->userStyleSheetLocation();
>      priv->settings.user_stylesheet = eina_stringshare_add(url.prettyURL().utf8().data());

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.