[Webkit-unassigned] [Bug 44190] [Cairo] Eliminate full-surface copy from canvas.drawImage(...)

Thu Aug 19 22:43:35 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=44190

Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64742|review?                     |review+
               Flag|                            |

--- Comment #2 from Dirk Schulze <krit at webkit.org>  2010-08-19 22:43:35 PST ---
(From update of attachment 64742)
WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:42
 +  #include <cmath>
Can you use <wtf/MathExtras.h> here? Think it's better to use the same math include all over WebKit (Also if you want to replace cmath with another math-lib for what ever reason).

WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:111
 +  void ImageBuffer::clip(GraphicsContext* context, const FloatRect& rect) const
Why did you add the variable names? As long as we don't implement clip, we should leave them out.

Patch looks great. Please change the snippets. r=me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.