[Webkit-unassigned] [Bug 44254] r64526 broke the GTK+-3 build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 19 16:45:10 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=44254


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #4 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-08-19 16:45:11 PST ---
Attachment 64909 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
Last 3072 characters of output:
its is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/CursorGtk.h:104:  moz_copy_bits is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/CursorGtk.h:117:  moz_copy_mask_bits is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/CursorGtk.h:131:  moz_alias_bits is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/CursorGtk.h:144:  moz_alias_mask_bits is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/CursorGtk.h:158:  moz_zoom_in_bits is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/CursorGtk.h:171:  moz_zoom_in_mask_bits is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/CursorGtk.h:185:  moz_zoom_out_bits is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/CursorGtk.h:198:  moz_zoom_out_mask_bits is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/CursorGtk.h:212:  moz_not_allowed_bits is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/CursorGtk.h:225:  moz_not_allowed_mask_bits is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/CursorGtk.h:239:  moz_spinning_bits is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/CursorGtk.h:252:  moz_spinning_mask_bits is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/CursorGtk.h:266:  moz_none_bits is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/CursorGtk.h:279:  moz_none_mask_bits is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/CursorGtk.h:293:  moz_hand_grab_bits is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/CursorGtk.h:306:  moz_hand_grab_mask_bits is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/CursorGtk.h:320:  moz_hand_grabbing_bits is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/CursorGtk.h:333:  moz_hand_grabbing_mask_bits is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/CursorGtk.h:363:  mask_bits is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 23 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list