[Webkit-unassigned] [Bug 44288] MarkupAccumulator::appendStartMarkup should be broken down into pieces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44288


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64897|0                           |1
        is obsolete|                            |
  Attachment #64897|review?                     |
               Flag|                            |
  Attachment #64901|                            |review?
               Flag|                            |




--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org>  2010-08-19 14:56:54 PST ---
Created an attachment (id=64901)
 --> (https://bugs.webkit.org/attachment.cgi?id=64901)
fixed "No new tests. (OOPS!)"

(In reply to comment #5)
> (From update of attachment 64897 [details])
> Thanks for working on this code.  It's blowing my mind too much to review properly.
> 
> WebCore/ChangeLog:14
>  +          No new tests. (OOPS!)
> This can't land with OOPS

Sorry, I meant to change that line to "No new tests are added since this is a cleanup." Fixed.

(In reply to comment #6)
> If you're going to do a lot of work on markup.cpp, please consider cleaning up all the style in a first pass.

Which function / part of code are you referring to?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.