[Webkit-unassigned] [Bug 44288] MarkupAccumulator::appendStartMarkup should be broken down into pieces

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 19 14:11:49 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=44288





--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2010-08-19 14:11:48 PST ---
(In reply to comment #3)
> Attachment 64897 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
> WebCore/editing/markup.cpp:636:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
> Total errors found: 1 in 2 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

This is a willful violation of the style guideline because the patch becomes unintelligible (svn diff tries to replace appendStartMarkup by appendElement, interleaving bits of pieces of both functions).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list