[Webkit-unassigned] [Bug 44280] Add modifier key info to policy client functions in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44280





--- Comment #3 from Sam Weinig <sam at webkit.org>  2010-08-19 12:02:05 PST ---
(In reply to comment #2)
> (From update of attachment 64883 [details])
> > @@ -521,21 +521,23 @@ void WebPageProxy::didReceiveMessage(Cor
> >          case WebPageProxyMessage::DecidePolicyForNavigationAction: {
> >              uint64_t frameID;
> >              uint32_t navigationType;
> > +            uint32_t modifiers;
> >              String url;
> >              uint64_t listenerID;
> > -            if (!arguments->decode(CoreIPC::Out(frameID, navigationType, url, listenerID)))
> > +            if (!arguments->decode(CoreIPC::Out(frameID, navigationType, modifiers, url, listenerID)))
> >                  return;
> > -            decidePolicyForNavigationAction(webFrame(frameID), static_cast<NavigationType>(navigationType), url, listenerID);
> > +            decidePolicyForNavigationAction(webFrame(frameID), static_cast<NavigationType>(navigationType), static_cast<WebEvent::Modifiers>(modifiers), url, listenerID);
> >              break;
> >          }
> >          case WebPageProxyMessage::DecidePolicyForNewWindowAction: {
> >              uint64_t frameID;
> >              uint32_t navigationType;
> > +            uint32_t modifiers;
> 
> Can we use WebEvent::Modifiers here?
> 

No. We need to give an explicit size when encoding/decoding. This will all be better with your typed IPC.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.