[Webkit-unassigned] [Bug 44195] [chromium] TilingData::tilePositionY has typo of X where Y should be used

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 19 08:34:40 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=44195





--- Comment #6 from David Levin <levin at chromium.org>  2010-08-19 08:34:40 PST ---
(In reply to comment #5)
> Layout tests are not yet possible for this code for a few reasons:
> - TilingData is currently only used behind a compile time flag as we develop GPU accelerated support for Canvas 2D. 

Yes but a layout test could be written that would hit this code when the flag is flipped.

> - TilingData is driven by a system GPU's maximum supported texture size, which varies on different hardware. We will need to plumb testing code that enables a layout test to supply a false value for GLES2Texture to mock as the maximium texture size at test time only.

Is there a current typically upper bound? How hard would it be to hit that (or some large multiple of that) for the layout test?

Lastly, why is this method recursive when a loop could easily do the same thing?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list