[Webkit-unassigned] [Bug 43181] Hook up LayoutTestController.setMockDeviceOrientation() on Mac.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43181





--- Comment #15 from Steve Block <steveblock at google.com>  2010-08-19 07:59:00 PST ---
Thanks for the review Simon. The reason for the numerous classes is that we're  implementing a WebCore client interface for which we need both a real and a mock implementation.

I've uploaded a new patch which eliminates the need for WebDeviceOrientationController by doing a runtime check. I think all of the other classes are required. I'm no expert on Mac, but I've followed the pattern used by Geolocation. Here's a summary of the new classes ...

- WebDeviceOrientationClient - Mac implementation of WebCore::DeviceOrientationClient. Acts a proxy to either the mock or real provider.
- WebDeviceOrientationProvider - New interface used by WebDeviceOrientationClient and implemented by the real and mock providers.
- WebDeviceOrientationProviderMock - Mock provider, wrapper around WebCore::DeviceOrientationClientMock
- WebDeviceOrientation - Wrapper around WebCore::DeviceOrientation. Required by DRT to configure the mock, without exposing WebCore types.

Where these classes are wrappers around WebCore types, I've used a FooInternal internal class to hide the WebCore types from the WebKit API.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.