[Webkit-unassigned] [Bug 42886] Web Inspector: implement DOM breakpoints

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42886





--- Comment #16 from Pavel Podivilov <podivilov at chromium.org>  2010-08-19 07:08:53 PST ---
(In reply to comment #14)
> (From update of attachment 64818 [details])
> WebCore/bindings/v8/ScriptDebugServer.cpp:368
>  +      ScriptState* currentCallFrameState = mainWorldScriptState(frame);
> This should be ScriptState::forContext where context is the one that was current before call to the debugger. Otherwise, if it wasn't a javascript code that triggered the mutation the stack would be empty and you could use main world script state. 
done

> WebCore/bindings/v8/ScriptDebugServer.h:135
>  +      OwnHandle<v8::Context> m_pausedPageContext;
> This one may be Local handle
done

> WebCore/inspector/InspectorDOMAgent.cpp:744
>  +      m_breakpoints.set(node, m_breakpoints.get(node) | rootBit & ~derivedBit);
> We discussed these bits with Pavel and it turns out that they don't need to be mutually exclusive. There should rather be two bits:
> 1. Indicates whether this node has a breakpoint set on it.
> 2. Whether we should pause on modifications of this node(currently it's deivedBit).
> So I'd suggest we rename them and don't reset derivedBit when setting breakpoint.

Probably it's more logical to use second bit to indicate if we have a derived breakpoint (there is a breakpoint set on ancestor). This will simplify breakpoint deletion (no need to check parent).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.