[Webkit-unassigned] [Bug 40793] [Cairo] The size of the shadow image uses the standard deviation size instead of the blur radius

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40793


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64823|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #24 from Dirk Schulze <krit at webkit.org>  2010-08-19 03:15:17 PST ---
(From update of attachment 64823)
WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:931
 +      sd = FEGaussianBlur::calculateStdDeviation(radius);
avoid the new line, just:
float sd = FEGaussianBlur::calculateStdDeviation(radius);

WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:934
 +      if (!radius || (!sd)) {
avoid the braces arround !sd

WebCore/platform/graphics/filters/FEGaussianBlur.cpp:203
 +  float FEGaussianBlur::calculateStdDeviation(const float& radius)
No need for const float& . We usally just use float for normal floats.

WebCore/platform/graphics/filters/FEGaussianBlur.h:46
 +      static float calculateStdDeviation(const float& radius);
make it const please.

Small changes. But please fix them before landing. r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.