[Webkit-unassigned] [Bug 44221] Add ability to get all the keys from a WKDictionaryRef

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44221


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64790|review?                     |review+
               Flag|                            |




--- Comment #2 from Adam Roben (aroben) <aroben at apple.com>  2010-08-18 21:41:19 PST ---
(From update of attachment 64790)
> +PassRefPtr<ImmutableArray> ImmutableDictionary::keys()

Can this be a const member function?

> +    size_t size = m_map.size();
> +    if (!size)

I thought we used isEmpty() for things like this.

> +    APIObject** array = new APIObject*[size];

I think using OwnArrayPtr would be better. Or, if not, why not make the type APIObject*[]?

> +    return ImmutableArray::adopt(array, size);

And this should take a PassOwnPtr!

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.