[Webkit-unassigned] [Bug 44223] [chromium] Fixing previous Mac only build breakage with TilingDataTest.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44223


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64793|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #3 from David Levin <levin at chromium.org>  2010-08-18 20:59:31 PST ---
(From update of attachment 64793)
> diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
> index 829705e95a9f714ab2c42befa1192a8bb6c5288e..2fa65e8a61d426dd73f4be6b0f91160de715f1dc 100644
> --- a/WebKit/chromium/ChangeLog
> +++ b/WebKit/chromium/ChangeLog
> @@ -1,3 +1,16 @@
> +2010-08-18  Vincent Scheib  <scheib at chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Fixing previous Mac only build breakage with TilingDataTest.cpp

Please include a link to the bug.

> +
> +        The test included the wrong header, which had a compile option around the definition of the WebCore namespace. Without the namespace defined, error. Fixed by correctly including TilingData.h, which has no conditional compilation.

The only place that I know of where lines are wrapped is in the ChangeLog.  Please break this line appropriately -- maybe around 80 columns.

> +
> +        Note: Style error is a false positive, since there is no .h file for TilingDataTest.cpp

No need to make a note in the ChangeLog about a stylebot error that is mention in the bug.

btw, that bug is https://bugs.webkit.org/show_bug.cgi?id=39514 if you feel inclined to fix it :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.