[Webkit-unassigned] [Bug 44215] Add ability to set custom userAgent for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44215


Jon Honeycutt <jhoneycutt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64786|review?                     |review+
               Flag|                            |




--- Comment #2 from Jon Honeycutt <jhoneycutt at apple.com>  2010-08-18 16:38:22 PST ---
(From update of attachment 64786)
 +String WebPage::userAgent()
> +{
> +    if (!m_customUserAgent.isNull())
> +        return m_customUserAgent;
> +
> +    // FIXME: This should be based on an application name.
> +    return  "Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6; en-us) AppleWebKit/531.4 (KHTML, like Gecko) Version/4.0.3 Safari/531.4";

Extra space after return.

> @@ -92,6 +92,7 @@ public:
>      // -- Called from WebCore clients.
>      bool handleEditingKeyboardEvent(WebCore::KeyboardEvent*);
>      void show();
> +    String userAgent();

Looks like this could be const.

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.