[Webkit-unassigned] [Bug 44101] [IndexedDB] Abort idle IDBTransactions when the JS context they were created in finishes execution.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44101


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64709|review?                     |review+
               Flag|                            |




--- Comment #6 from Jeremy Orlow <jorlow at chromium.org>  2010-08-18 08:26:45 PST ---
(From update of attachment 64709)
WebKit/chromium/src/WebIDBTransactionImpl.h:54
 +  
extra newline

WebCore/storage/IDBPendingTransactionMonitor.cpp:37
 +      return (m_ids && m_ids->size());
no need for ()'s

WebCore/storage/IDBPendingTransactionMonitor.cpp:58
 +      m_ids->clear();
Hm...might be worth to have this do a if (m_ids) check?

WebCore/storage/IDBPendingTransactionMonitor.cpp:47
 +  void IDBPendingTransactionMonitor::removePendingTransaction(int id)
I'm tempted to say this should be a set rather than a vector...but at the same time I don't see the list ever getting very big.

WebCore/storage/IDBPendingTransactionMonitor.h:51
 +      static const Vector<int>& pendingTransactions();
newline after

WebCore/storage/IDBTransactionCoordinator.cpp:1
 +  #include "config.h"
license!


r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.