[Webkit-unassigned] [Bug 41842] Add feature detection support for NRWT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 18 06:31:56 PDT 2010


--- Comment #21 from Gabor Rapcsanyi <rgabor at inf.u-szeged.hu>  2010-08-18 06:31:55 PST ---
(In reply to comment #20)
> (From update of attachment 64576 [details])
> WebKitTools/Scripts/webkitpy/layout_tests/port/base.py:662
>  +      def _path_to_library(self):
> This should really be _path_to_webcore, since these symbols are searched for in WebCore, not WebKit on ports which don't build all-as one.
> WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py:228
>  +              symbol_list = os.popen(driver_path + " --print-supported-features 2>&1").readlines()
> We actually want to move to this model for all ports.
> WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py:221
>  +      def _get_supported_features_symbols(self):
> This name doesnt' make a lot of sense since it's not symbols on win32.  Seems like we should have a separate path for ports which use symbols vs. supported features, no?
> WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py:239
>  +          if sys.platform in ('cygwin', 'win32'):
> Yeah, these are tottally separate code paths.  Lets not conflate them.
> One unit test is not sufficient for this complexity of code.
> This looks fine in general.  But please separate out the runtime list lookup vs. the symbol lookup. Basically we should try running "print-supported-features" and if that erros out, fall back to nm on all platforms (would be my suggestion).
> Thank you so much for looking at this!

Hi Eric!

This fall-back idea sounds good but on Qt and Gtk ports the DRT ignores this switch, gets going and blocks NRWT if we execute it, like if there only were a - switch.
If we want to do this I see two ways. Change all port's DRTs which are blocking with this switch, or make a more complex explicit DRT execution routine in a separate function.
What do you think about this?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list