[Webkit-unassigned] [Bug 43882] [Qt] Move the accelerated compositing build flag to the right place

Wed Aug 18 05:16:30 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=43882

Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64676|review?                     |review+, commit-queue-
               Flag|                            |

--- Comment #12 from Antonio Gomes <tonikitoo at webkit.org>  2010-08-18 05:16:30 PST ---
(From update of attachment 64676)
Noam, the patch looks good. One major comment below though.

>  2010-08-17  Gavin Barraclough  <barraclough at apple.com>
>  
>          Reviewed by Sam Weinig.
> diff --git a/JavaScriptCore/wtf/Platform.h b/JavaScriptCore/wtf/Platform.h
> index f653adb2c0a59e6add35b821d1ec139a2c38583a..78968a900d12df7728f1b258a9c546ab1d9ea2e5 100644
> --- a/JavaScriptCore/wtf/Platform.h
> +++ b/JavaScriptCore/wtf/Platform.h
> @@ -1052,7 +1052,7 @@ on MinGW. See https://bugs.webkit.org/show_bug.cgi?id=29268 */
>  #define WTF_USE_ACCELERATED_COMPOSITING 1
>  #endif
>  
> -#if PLATFORM(QT)
> +#if PLATFORM(QT) && !(defined(QT_VERSION) && QT_VERSION < 0x040600) && !defined(WTF_USE_ACCELERATED_COMPOSITING)
>  #define WTF_USE_ACCELERATED_COMPOSITING 1
>  #endif

in bug 43695, we moved away from using the  encoded hex for qt version check. could you keep the consistency?

The rest is fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.