[Webkit-unassigned] [Bug 44147] [EFL] enable libsoup's content decode feature

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 17 21:42:24 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=44147


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64661|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Antonio Gomes <tonikitoo at webkit.org>  2010-08-17 21:42:24 PST ---
(From update of attachment 64661)
r=me

> +        [EFL] enable libsoup's content decode feature
> +        https://bugs.webkit.org/show_bug.cgi?id=44147
> +
> +        libsoup's content decode feature is enabled during initializaton.

Please, rephrase to something like: "Enable libsoup's content decode feature..." or "Make libsoup's content decode feature is enabled during initializaton to fix web sites that send CSS encoded", blablabla. Something more descriptive.

ps: When uploading the new patch , fill "Reviewed by" statement in the ChangeLog with "Antonio Gomes" and just set "cq?" to the patch. No need for a new 

> --- a/WebKit/efl/ewk/ewk_main.cpp
> +++ b/WebKit/efl/ewk/ewk_main.cpp
> @@ -125,6 +125,7 @@ int ewk_init(void)
>      if (1) {
>          SoupSession* session = WebCore::ResourceHandle::defaultSession();
>          soup_session_add_feature_by_type(session, SOUP_TYPE_CONTENT_SNIFFER);
> +        soup_session_add_feature_by_type(session, SOUP_TYPE_CONTENT_DECODER);
>      }
>  #endif  

the if (1) above made me sad! :-(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list