[Webkit-unassigned] [Bug 43882] [Qt] Move the accelerated compositing build flag to the right place

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43882





--- Comment #9 from Antonio Gomes <tonikitoo at webkit.org>  2010-08-17 20:21:29 PST ---
(In reply to comment #8)
> We are defining WTF_USE_ACCELERATED_COMPOSITING in WebKit.pri too (line 48):
> greaterThan(QT_MINOR_VERSION, 5):DEFINES += WTF_USE_ACCELERATED_COMPOSITING

It sounds bogus now. Could you please file a bug?

> If it should be done in Platform.h then I think it should be done this way:
> #if PLATFORM(QT)
> #ifndef !defined(WTF_USE_ACCELERATED_COMPOSITING) && QT_VERSION_GREATER_THEN(4, 5, 0)
> #define WTF_USE_ACCELERATED_COMPOSITING 1
> #endif
> #endif
> 
> With this the feature could be disabled at compile time and the version check would still exist. Do you agree?
> (I am not sure that the QT_VERSION_GREATER_THEN macro exist but I know there is something like that.)

"#if QT_VERSION >= QT_VERSION_CHECK(4, 6, 0)"

Personally, I support moving all "#defined" dealed here to Platform.h

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.