[Webkit-unassigned] [Bug 44107] CSS: Make rgb() and rgba() fast paths case-insensitive

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 17 17:36:54 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=44107





--- Comment #3 from Andreas Kling <andreas.kling at nokia.com>  2010-08-17 17:36:54 PST ---
(In reply to comment #2)
> (From update of attachment 64588 [details])
> > -    if (name.startsWith("rgba(")) {
> > +    if (mightBeRGBA(characters, length)) {
> 
> Will there be a (minor) behavior difference IF the input is invalid e.g. "rgba(foo"?

The invalid string "rgba(foo" will fail via Color::setNamedColor() below instead of inside the fast rgba() parser.

Behavior won't change but you have a point - it will be slightly slower for invalid strings. I will update the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list